This repository has been archived by the owner on May 5, 2021. It is now read-only.
Fix opacity issue with caption container #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing the caption containers opacity this will directly impact the opacity of the content as well, which may not be desired behavior (in my case). To allow for independent changes to the background color opacity two more elements are required as usually with modal dialogs. This PR adds these elements - one for the backdrop and one for the caption text allowing to access and style it.
Changes to base stylesheet required to style the caption opacity independently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the caption containers opacity this will directly impact the opacity of the content as well, which may not be desired behavior (in my case). To allow for independent changes to the background color opacity two more elements are required as usually with modal dialogs. This PR adds these elements - one for the backdrop and one for the caption text allowing to access and style it.